Skip to content

Implement (part of) ACP 429: add DerefMut to Lazy[Cell/Lock] #129334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2025

Conversation

ChayimFriedman2
Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 commented Aug 20, 2024

DerefMut is instantly stable, as a trait impl. That means this needs an FCP.

@rustbot label +needs-fcp

rust-lang/libs-team#429

@rustbot
Copy link
Collaborator

rustbot commented Aug 20, 2024

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. labels Aug 20, 2024
@ChayimFriedman2
Copy link
Contributor Author

ChayimFriedman2 commented Aug 20, 2024

r​? libs-api

@joboet
Copy link
Member

joboet commented Aug 21, 2024

Weird, rustbot seems to be sleeping...
r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Aug 21, 2024
@rustbot rustbot assigned BurntSushi and unassigned joboet Aug 21, 2024
Copy link
Member

@joboet joboet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good to me, r=me with the nit resolved after the FCP completes.

@SteveLauC
Copy link
Contributor

Gentle ping on this PR, would love this to be merged soon:)

@ChayimFriedman2
Copy link
Contributor Author

@SteveLauC This depends on a T-libs-api member starting a FCP.

Copy link
Member

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New APIs need to land as unstable. And an FCP isn't needed for that. There should also be a tracking issue. And the ACP should be linked.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2024
@scottmcm
Copy link
Member

Looks like this PR includes DerefMut, which is a trait impl, so that part does need an FCP.

Can you split this into two? One that's just T-libs and only adds unstable methods, and one that's T-libs-api with the stable trait impl. The former can land much more easily than the latter.

@ChayimFriedman2
Copy link
Contributor Author

@BurntSushi @scottmcm This PR needs FCP for DerefMut and force_mut(), which, as I said in the OP, I decided to make instantly stable because it makes little sense to separate it from DerefMut.

For get_mut(), I already opened a tracking issue: #129333. I can split the PR though.

@workingjubilee
Copy link
Member

DerefMut is instantly stable, as a trait impl; as such, I decided to also instantly stabilize force_mut(), since it makes little sense to have one but not the other. That means this needs an FCP.

so you're saying we could land force_mut() on nightly as unstable and then decide to stabilize DerefMut with it?

@ChayimFriedman2
Copy link
Contributor Author

DerefMut is instantly stable, as a trait impl; as such, I decided to also instantly stabilize force_mut(), since it makes little sense to have one but not the other. That means this needs an FCP.

so you're saying we could land force_mut() on nightly as unstable and then decide to stabilize DerefMut with it?

That's an option, but that's not what I'm doing in this PR. Instead, I instantly stabilize both.

@bors
Copy link
Collaborator

bors commented Sep 19, 2024

☔ The latest upstream changes (presumably #130534) made this pull request unmergeable. Please resolve the merge conflicts.

@ChayimFriedman2
Copy link
Contributor Author

@rustbot ready

I modified this to only add (immediately stable) DerefMut, after the other methods has been added unstably in #130476. This is now ready for FCP.

Although, libs-api may not want to include this until force_mut() stabilizes, or people may resort to this as a workaround (although I expect DerefMut to be used more often anyway, just like Deref vs. force()).

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 16, 2024
@rfcbot rfcbot added disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Apr 29, 2025
@rfcbot
Copy link
Collaborator

rfcbot commented Apr 29, 2025

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Apr 29, 2025
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels May 9, 2025
@rfcbot
Copy link
Collaborator

rfcbot commented May 9, 2025

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@Amanieu
Copy link
Member

Amanieu commented May 9, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented May 9, 2025

📌 Commit b208706 has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request May 10, 2025
… r=Amanieu

Implement (part of) ACP 429: add `DerefMut` to `Lazy[Cell/Lock]`

`DerefMut` is instantly stable, as a trait impl. That means this needs an FCP.

`@rustbot` label +needs-fcp

rust-lang/libs-team#429
bors added a commit to rust-lang-ci/rust that referenced this pull request May 10, 2025
Rollup of 10 pull requests

Successful merges:

 - rust-lang#129334 (Implement (part of) ACP 429: add `DerefMut` to `Lazy[Cell/Lock]`)
 - rust-lang#135015 (Partially stabilize LoongArch target features)
 - rust-lang#138736 (Sanitizers target modificators)
 - rust-lang#139562 (rustdoc: add a handle that makes sidebar resizing more obvious)
 - rust-lang#140151 (remove intrinsics::drop_in_place)
 - rust-lang#140660 (remove 'unordered' atomic intrinsics)
 - rust-lang#140783 (Update documentation of OnceLock::get_or_init.)
 - rust-lang#140789 (Update hermit-abi to 0.5.1)
 - rust-lang#140792 (Use intrinsics for `{f16,f32,f64,f128}::{minimum,maximum}` operations)
 - rust-lang#140862 (Enable non-leaf Frame Pointers for Arm64EC Windows)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 10, 2025
… r=Amanieu

Implement (part of) ACP 429: add `DerefMut` to `Lazy[Cell/Lock]`

`DerefMut` is instantly stable, as a trait impl. That means this needs an FCP.

`@rustbot` label +needs-fcp

rust-lang/libs-team#429
bors added a commit to rust-lang-ci/rust that referenced this pull request May 10, 2025
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#129334 (Implement (part of) ACP 429: add `DerefMut` to `Lazy[Cell/Lock]`)
 - rust-lang#139562 (rustdoc: add a handle that makes sidebar resizing more obvious)
 - rust-lang#140151 (remove intrinsics::drop_in_place)
 - rust-lang#140660 (remove 'unordered' atomic intrinsics)
 - rust-lang#140783 (Update documentation of OnceLock::get_or_init.)
 - rust-lang#140789 (Update hermit-abi to 0.5.1)
 - rust-lang#140792 (Use intrinsics for `{f16,f32,f64,f128}::{minimum,maximum}` operations)
 - rust-lang#140879 (1.87.0 release notes: remove nonsensical `~` operator)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request May 10, 2025
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#129334 (Implement (part of) ACP 429: add `DerefMut` to `Lazy[Cell/Lock]`)
 - rust-lang#139562 (rustdoc: add a handle that makes sidebar resizing more obvious)
 - rust-lang#140151 (remove intrinsics::drop_in_place)
 - rust-lang#140660 (remove 'unordered' atomic intrinsics)
 - rust-lang#140783 (Update documentation of OnceLock::get_or_init.)
 - rust-lang#140789 (Update hermit-abi to 0.5.1)
 - rust-lang#140879 (1.87.0 release notes: remove nonsensical `~` operator)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c6b9253 into rust-lang:master May 10, 2025
6 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 10, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 10, 2025
Rollup merge of rust-lang#129334 - ChayimFriedman2:more-lazy-methods, r=Amanieu

Implement (part of) ACP 429: add `DerefMut` to `Lazy[Cell/Lock]`

`DerefMut` is instantly stable, as a trait impl. That means this needs an FCP.

``@rustbot`` label +needs-fcp

rust-lang/libs-team#429
@ChayimFriedman2 ChayimFriedman2 deleted the more-lazy-methods branch May 10, 2025 21:27
github-actions bot pushed a commit to carolynzech/rust that referenced this pull request May 16, 2025
… r=Amanieu

Implement (part of) ACP 429: add `DerefMut` to `Lazy[Cell/Lock]`

`DerefMut` is instantly stable, as a trait impl. That means this needs an FCP.

``@rustbot`` label +needs-fcp

rust-lang/libs-team#429
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jun 5, 2025
wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this pull request Aug 11, 2025
Pkgsrc changes:
 * Adjust patches to adapt to upstream changes and new versions.
 * assosicated checksums

Upstream changes relative to 1.88.0:

Version 1.89.0 (2025-08-07)
==========================

Language
--------
- [Stabilize explicitly inferred const arguments (`feature(generic_arg_infer)`)]
  (rust-lang/rust#141610)
- [Add a warn-by-default `mismatched_lifetime_syntaxes` lint.]
  (rust-lang/rust#138677)
  This lint detects when the same lifetime is referred to by
  different syntax categories between function arguments and return
  values, which can be confusing to read, especially in unsafe
  code.  This lint supersedes the warn-by-default `elided_named_lifetimes`
  lint.
- [Expand `unpredictable_function_pointer_comparisons` to also lint
  on function pointer comparisons in external macros]
  (rust-lang/rust#134536)
- [Make the `dangerous_implicit_autorefs` lint deny-by-default]
  (rust-lang/rust#141661)
- [Stabilize the avx512 target features]
  (rust-lang/rust#138940)
- [Stabilize `kl` and `widekl` target features for x86]
  (rust-lang/rust#140766)
- [Stabilize `sha512`, `sm3` and `sm4` target features for x86]
  (rust-lang/rust#140767)
- [Stabilize LoongArch target features `f`, `d`, `frecipe`, `lasx`,
  `lbt`, `lsx`, and `lvz`]
  (rust-lang/rust#135015)
- [Remove `i128` and `u128` from `improper_ctypes_definitions`]
  (rust-lang/rust#137306)
- [Stabilize `repr128` (`#[repr(u128)]`, `#[repr(i128)]`)]
  (rust-lang/rust#138285)
- [Allow `#![doc(test(attr(..)))]` everywhere]
  (rust-lang/rust#140560)
- [Extend temporary lifetime extension to also go through tuple
  struct and tuple variant constructors]
  (rust-lang/rust#140593)

Compiler
--------
- [Default to non-leaf frame pointers on aarch64-linux]
  (rust-lang/rust#140832)
- [Enable non-leaf frame pointers for Arm64EC Windows]
  (rust-lang/rust#140862)
- [Set Apple frame pointers by architecture]
  (rust-lang/rust#141797)

Platform Support
----------------
- [Add new Tier-3 targets `loongarch32-unknown-none` and
  `loongarch32-unknown-none-softfloat`]
  (rust-lang/rust#142053)

Refer to Rust's [platform support page][platform-support-doc]
for more information on Rust's tiered platform support.

[platform-support-doc]: https://doc.rust-lang.org/rustc/platform-support.html

Libraries
---------
- [Specify the base path for `file!`]
  (rust-lang/rust#134442)
- [Allow storing `format_args!()` in a variable]
  (rust-lang/rust#140748)
- [Add `#[must_use]` to `[T; N]::map`]
  (rust-lang/rust#140957)
- [Implement `DerefMut` for `Lazy{Cell,Lock}`]
  (rust-lang/rust#129334)
- [Implement `Default` for `array::IntoIter`]
  (rust-lang/rust#141574)
- [Implement `Clone` for `slice::ChunkBy`]
  (rust-lang/rust#138016)
- [Implement `io::Seek` for `io::Take`]
  (rust-lang/rust#138023)

Stabilized APIs
---------------

- [`NonZero<char>`]
  (https://doc.rust-lang.org/stable/std/num/struct.NonZero.html)
- Many intrinsics for x86, not enumerated here
  - [AVX512 intrinsics](rust-lang/rust#111137)
  - [`SHA512`, `SM3` and `SM4` intrinsics]
    (rust-lang/rust#126624)
- [`File::lock`]
  (https://doc.rust-lang.org/stable/std/fs/struct.File.html#method.lock)
- [`File::lock_shared`]
  (https://doc.rust-lang.org/stable/std/fs/struct.File.html#method.lock_shared)
- [`File::try_lock`]
  (https://doc.rust-lang.org/stable/std/fs/struct.File.html#method.try_lock)
- [`File::try_lock_shared`]
  (https://doc.rust-lang.org/stable/std/fs/struct.File.html#method.try_lock_shared)
- [`File::unlock`]
  (https://doc.rust-lang.org/stable/std/fs/struct.File.html#method.unlock)
- [`NonNull::from_ref`]
  (https://doc.rust-lang.org/stable/std/ptr/struct.NonNull.html#method.from_ref)
- [`NonNull::from_mut`]
  (https://doc.rust-lang.org/stable/std/ptr/struct.NonNull.html#method.from_mut)
- [`NonNull::without_provenance`]
  (https://doc.rust-lang.org/stable/std/ptr/struct.NonNull.html#method.without_provenance)
- [`NonNull::with_exposed_provenance`]
  (https://doc.rust-lang.org/stable/std/ptr/struct.NonNull.html#method.with_exposed_provenance)
- [`NonNull::expose_provenance`]
  (https://doc.rust-lang.org/stable/std/ptr/struct.NonNull.html#method.expose_provenance)
- [`OsString::leak`]
  (https://doc.rust-lang.org/stable/std/ffi/struct.OsString.html#method.leak)
- [`PathBuf::leak`]
  (https://doc.rust-lang.org/stable/std/path/struct.PathBuf.html#method.leak)
- [`Result::flatten`]
  (https://doc.rust-lang.org/stable/std/result/enum.Result.html#method.flatten)
- [`std::os::linux::net::TcpStreamExt::quickack`]
  (https://doc.rust-lang.org/stable/std/os/linux/net/trait.TcpStreamExt.html#tymethod.quickack)
- [`std::os::linux::net::TcpStreamExt::set_quickack`]
  (https://doc.rust-lang.org/stable/std/os/linux/net/trait.TcpStreamExt.html#tymethod.set_quickack)

These previously stable APIs are now stable in const contexts:

- [`<[T; N]>::as_mut_slice`]
  (https://doc.rust-lang.org/stable/std/primitive.array.html#method.as_mut_slice)
- [`<[u8]>::eq_ignore_ascii_case`]
  (https://doc.rust-lang.org/stable/std/primitive.slice.html#impl-%5Bu8%5D/method.eq_ignore_ascii_case)
- [`str::eq_ignore_ascii_case`]
  (https://doc.rust-lang.org/stable/std/primitive.str.html#impl-str/method.eq_ignore_ascii_case)

Cargo
-----
- [`cargo fix` and `cargo clippy --fix` now default to the same
  Cargo target selection as other build commands.]
  (rust-lang/cargo#15192) Previously it
  would apply to all targets (like binaries, examples, tests, etc.).
  The `--edition` flag still applies to all targets.

- [Stabilize doctest-xcompile.]
  (rust-lang/cargo#15462) Doctests are
  now tested when cross-compiling. Just like other tests, it will
  use the [`runner` setting]
  (https://doc.rust-lang.org/cargo/reference/config.html#targettriplerunner)
  to run the tests. If you need to disable tests for a target, you
  can use the [ignore doctest attribute]
  (https://doc.rust-lang.org/rustdoc/write-documentation/documentation-tests.html#ignoring-targets)
  to specify the targets to ignore.

Rustdoc
-----
- [On mobile, make the sidebar full width and linewrap]
  (rust-lang/rust#139831). This makes long
  section and item names much easier to deal with on mobile.

Compatibility Notes
-------------------
- [Make `missing_fragment_specifier` an unconditional error]
  (rust-lang/rust#128425)
- [Enabling the `neon` target feature on `aarch64-unknown-none-softfloat`
  causes a warning]
  (rust-lang/rust#135160) because mixing
  code with and without that target feature is not properly supported
  by LLVM
- [Sized Hierarchy: Part I](rust-lang/rust#137944)
  - Introduces a small breaking change affecting `?Sized` bounds
    on impls on recursive types which contain associated type
    projections. It is not expected to affect any existing published
    crates. Can be fixed by refactoring the involved types or opting
    into the `sized_hierarchy` unstable feature. See the [FCP report]
    (rust-lang/rust#137944 (comment))
    for a code example.
- The warn-by-default `elided_named_lifetimes` lint is [superseded
  by the warn-by-default `mismatched_lifetime_syntaxes` lint.]
  (rust-lang/rust#138677)
- [Error on recursive opaque types earlier in the type checker]
  (rust-lang/rust#139419)
- [Type inference side effects from requiring element types of
  array repeat expressions are `Copy` are now only available at the
  end of type checking]
  (rust-lang/rust#139635)

- [The deprecated accidentally-stable
  `std::intrinsics::{copy,copy_nonoverlapping,write_bytes}` are now
  proper intrinsics]
  (rust-lang/rust#139916). There are no
  debug assertions guarding against UB, and they cannot be coerced
  to function pointers.
- [Remove long-deprecated `std::intrinsics::drop_in_place`]
  (rust-lang/rust#140151)
- [Make well-formedness predicates no longer coinductive]
  (rust-lang/rust#140208)
- [Remove hack when checking impl method compatibility]
  (rust-lang/rust#140557)
- [Remove unnecessary type inference due to built-in trait object impls]
  (rust-lang/rust#141352)
- [Lint against "stdcall", "fastcall", and "cdecl" on non-x86-32 targets]
  (rust-lang/rust#141435)
- [Future incompatibility warnings relating to the never type (`!`)
  are now reported in dependencies]
  (rust-lang/rust#141937)
- [Ensure `std::ptr::copy_*` intrinsics also perform the static
  self-init checks]
  (rust-lang/rust#142575)

Internal Changes
----------------

These changes do not affect any public interfaces of Rust, but they represent
significant improvements to the performance or internals of rustc and related
tools.

- [Correctly un-remap compiler sources paths with the `rustc-dev` component]
  (rust-lang/rust#142377)
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Aug 12, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [rust](https://github.com/rust-lang/rust) | minor | `1.88.0` -> `1.89.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>rust-lang/rust (rust)</summary>

### [`v1.89.0`](https://github.com/rust-lang/rust/blob/HEAD/RELEASES.md#Version-1890-2025-08-07)

[Compare Source](rust-lang/rust@1.88.0...1.89.0)

\==========================

<a id="1.89.0-Language"></a>

## Language

- [Stabilize explicitly inferred const arguments (`feature(generic_arg_infer)`)](rust-lang/rust#141610)
- [Add a warn-by-default `mismatched_lifetime_syntaxes` lint.](rust-lang/rust#138677)
  This lint detects when the same lifetime is referred to by different syntax categories between function arguments and return values, which can be confusing to read, especially in unsafe code.
  This lint supersedes the warn-by-default `elided_named_lifetimes` lint.
- [Expand `unpredictable_function_pointer_comparisons` to also lint on function pointer comparisons in external macros](rust-lang/rust#134536)
- [Make the `dangerous_implicit_autorefs` lint deny-by-default](rust-lang/rust#141661)
- [Stabilize the avx512 target features](rust-lang/rust#138940)
- [Stabilize `kl` and `widekl` target features for x86](rust-lang/rust#140766)
- [Stabilize `sha512`, `sm3` and `sm4` target features for x86](rust-lang/rust#140767)
- [Stabilize LoongArch target features `f`, `d`, `frecipe`, `lasx`, `lbt`, `lsx`, and `lvz`](rust-lang/rust#135015)
- [Remove `i128` and `u128` from `improper_ctypes_definitions`](rust-lang/rust#137306)
- [Stabilize `repr128` (`#[repr(u128)]`, `#[repr(i128)]`)](rust-lang/rust#138285)
- [Allow `#![doc(test(attr(..)))]` everywhere](rust-lang/rust#140560)
- [Extend temporary lifetime extension to also go through tuple struct and tuple variant constructors](rust-lang/rust#140593)
- [`extern "C"` functions on the `wasm32-unknown-unknown` target now have a standards compliant ABI](https://blog.rust-lang.org/2025/04/04/c-abi-changes-for-wasm32-unknown-unknown/)

<a id="1.89.0-Compiler"></a>

## Compiler

- [Default to non-leaf frame pointers on aarch64-linux](rust-lang/rust#140832)
- [Enable non-leaf frame pointers for Arm64EC Windows](rust-lang/rust#140862)
- [Set Apple frame pointers by architecture](rust-lang/rust#141797)

<a id="1.89.0-Platform-Support"></a>

## Platform Support

- [Add new Tier-3 targets `loongarch32-unknown-none` and `loongarch32-unknown-none-softfloat`](rust-lang/rust#142053)
- [`x86_64-apple-darwin` is in the process of being demoted to Tier 2 with host tools](rust-lang/rfcs#3841)

Refer to Rust's [platform support page][platform-support-doc]
for more information on Rust's tiered platform support.

[platform-support-doc]: https://doc.rust-lang.org/rustc/platform-support.html

<a id="1.89.0-Libraries"></a>

## Libraries

- [Specify the base path for `file!`](rust-lang/rust#134442)
- [Allow storing `format_args!()` in a variable](rust-lang/rust#140748)
- [Add `#[must_use]` to `[T; N]::map`](rust-lang/rust#140957)
- [Implement `DerefMut` for `Lazy{Cell,Lock}`](rust-lang/rust#129334)
- [Implement `Default` for `array::IntoIter`](rust-lang/rust#141574)
- [Implement `Clone` for `slice::ChunkBy`](rust-lang/rust#138016)
- [Implement `io::Seek` for `io::Take`](rust-lang/rust#138023)

<a id="1.89.0-Stabilized-APIs"></a>

## Stabilized APIs

- [`NonZero<char>`](https://doc.rust-lang.org/stable/std/num/struct.NonZero.html)
- Many intrinsics for x86, not enumerated here
  - [AVX512 intrinsics](rust-lang/rust#111137)
  - [`SHA512`, `SM3` and `SM4` intrinsics](rust-lang/rust#126624)
- [`File::lock`](https://doc.rust-lang.org/stable/std/fs/struct.File.html#method.lock)
- [`File::lock_shared`](https://doc.rust-lang.org/stable/std/fs/struct.File.html#method.lock_shared)
- [`File::try_lock`](https://doc.rust-lang.org/stable/std/fs/struct.File.html#method.try_lock)
- [`File::try_lock_shared`](https://doc.rust-lang.org/stable/std/fs/struct.File.html#method.try_lock_shared)
- [`File::unlock`](https://doc.rust-lang.org/stable/std/fs/struct.File.html#method.unlock)
- [`NonNull::from_ref`](https://doc.rust-lang.org/stable/std/ptr/struct.NonNull.html#method.from_ref)
- [`NonNull::from_mut`](https://doc.rust-lang.org/stable/std/ptr/struct.NonNull.html#method.from_mut)
- [`NonNull::without_provenance`](https://doc.rust-lang.org/stable/std/ptr/struct.NonNull.html#method.without_provenance)
- [`NonNull::with_exposed_provenance`](https://doc.rust-lang.org/stable/std/ptr/struct.NonNull.html#method.with_exposed_provenance)
- [`NonNull::expose_provenance`](https://doc.rust-lang.org/stable/std/ptr/struct.NonNull.html#method.expose_provenance)
- [`OsString::leak`](https://doc.rust-lang.org/stable/std/ffi/struct.OsString.html#method.leak)
- [`PathBuf::leak`](https://doc.rust-lang.org/stable/std/path/struct.PathBuf.html#method.leak)
- [`Result::flatten`](https://doc.rust-lang.org/stable/std/result/enum.Result.html#method.flatten)
- [`std::os::linux::net::TcpStreamExt::quickack`](https://doc.rust-lang.org/stable/std/os/linux/net/trait.TcpStreamExt.html#tymethod.quickack)
- [`std::os::linux::net::TcpStreamExt::set_quickack`](https://doc.rust-lang.org/stable/std/os/linux/net/trait.TcpStreamExt.html#tymethod.set_quickack)

These previously stable APIs are now stable in const contexts:

- [`<[T; N]>::as_mut_slice`](https://doc.rust-lang.org/stable/std/primitive.array.html#method.as_mut_slice)
- [`<[u8]>::eq_ignore_ascii_case`](https://doc.rust-lang.org/stable/std/primitive.slice.html#impl-%5Bu8%5D/method.eq_ignore_ascii_case)
- [`str::eq_ignore_ascii_case`](https://doc.rust-lang.org/stable/std/primitive.str.html#impl-str/method.eq_ignore_ascii_case)

<a id="1.89.0-Cargo"></a>

## Cargo

- [`cargo fix` and `cargo clippy --fix` now default to the same Cargo target selection as other build commands.](rust-lang/cargo#15192) Previously it would apply to all targets (like binaries, examples, tests, etc.). The `--edition` flag still applies to all targets.
- [Stabilize doctest-xcompile.](rust-lang/cargo#15462) Doctests are now tested when cross-compiling. Just like other tests, it will use the [`runner` setting](https://doc.rust-lang.org/cargo/reference/config.html#targettriplerunner) to run the tests. If you need to disable tests for a target, you can use the [ignore doctest attribute](https://doc.rust-lang.org/rustdoc/write-documentation/documentation-tests.html#ignoring-targets) to specify the targets to ignore.

<a id="1.89.0-Rustdoc"></a>

## Rustdoc

- [On mobile, make the sidebar full width and linewrap](rust-lang/rust#139831). This makes long section and item names much easier to deal with on mobile.

<a id="1.89.0-Compatibility-Notes"></a>

## Compatibility Notes

- [Make `missing_fragment_specifier` an unconditional error](rust-lang/rust#128425)
- [Enabling the `neon` target feature on `aarch64-unknown-none-softfloat` causes a warning](rust-lang/rust#135160) because mixing code with and without that target feature is not properly supported by LLVM
- [Sized Hierarchy: Part I](rust-lang/rust#137944)
  - Introduces a small breaking change affecting `?Sized` bounds on impls on recursive types which contain associated type projections. It is not expected to affect any existing published crates. Can be fixed by refactoring the involved types or opting into the `sized_hierarchy` unstable feature. See the [FCP report](rust-lang/rust#137944 (comment)) for a code example.
- The warn-by-default `elided_named_lifetimes` lint is [superseded by the warn-by-default `mismatched_lifetime_syntaxes` lint.](rust-lang/rust#138677)
- [Error on recursive opaque types earlier in the type checker](rust-lang/rust#139419)
- [Type inference side effects from requiring element types of array repeat expressions are `Copy` are now only available at the end of type checking](rust-lang/rust#139635)
- [The deprecated accidentally-stable `std::intrinsics::{copy,copy_nonoverlapping,write_bytes}` are now proper intrinsics](rust-lang/rust#139916). There are no debug assertions guarding against UB, and they cannot be coerced to function pointers.
- [Remove long-deprecated `std::intrinsics::drop_in_place`](rust-lang/rust#140151)
- [Make well-formedness predicates no longer coinductive](rust-lang/rust#140208)
- [Remove hack when checking impl method compatibility](rust-lang/rust#140557)
- [Remove unnecessary type inference due to built-in trait object impls](rust-lang/rust#141352)
- [Lint against "stdcall", "fastcall", and "cdecl" on non-x86-32 targets](rust-lang/rust#141435)
- [Future incompatibility warnings relating to the never type (`!`) are now reported in dependencies](rust-lang/rust#141937)
- [Ensure `std::ptr::copy_*` intrinsics also perform the static self-init checks](rust-lang/rust#142575)
- [`extern "C"` functions on the `wasm32-unknown-unknown` target now have a standards compliant ABI](https://blog.rust-lang.org/2025/04/04/c-abi-changes-for-wasm32-unknown-unknown/)

<a id="1.89.0-Internal-Changes"></a>

## Internal Changes

These changes do not affect any public interfaces of Rust, but they represent
significant improvements to the performance or internals of rustc and related
tools.

- [Correctly un-remap compiler sources paths with the `rustc-dev` component](rust-lang/rust#142377)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS41NS4yIiwidXBkYXRlZEluVmVyIjoiNDEuNTUuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.